Fix PyTorch multivariate_normal array-like inputs#2228
Open
FlorianPfaff wants to merge 2 commits into
Open
Conversation
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ COPYPASTE | jscpd | yes | no | no | 42.61s | |
| ✅ JSON | prettier | 7 | 0 | 0 | 0 | 1.03s |
| ✅ JSON | v8r | 7 | 0 | 0 | 4.84s | |
| markdownlint | 66 | 0 | 1 | 0 | 1.89s | |
| ✅ MARKDOWN | markdown-table-formatter | 66 | 0 | 0 | 0 | 0.77s |
| ✅ PYTHON | black | 759 | 2 | 0 | 0 | 40.86s |
| ✅ PYTHON | isort | 759 | 2 | 0 | 0 | 2.42s |
| ✅ REPOSITORY | checkov | yes | no | no | 47.22s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 16.98s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.11s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 22.87s | |
| ✅ REPOSITORY | syft | yes | no | no | 6.41s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 6.7s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 23.34s | |
| ✅ YAML | prettier | 11 | 0 | 0 | 0 | 0.73s |
| ✅ YAML | v8r | 11 | 0 | 0 | 11.72s | |
| ✅ YAML | yamllint | 11 | 0 | 0 | 0.55s |
Detailed Issues
⚠️ MARKDOWN / markdownlint - 1 error
.github/pull_request_template.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "## Summary"]
Notices
📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
FlorianPfaff
force-pushed
the
codex/fix-pytorch-mvn-list-inputs
branch
from
5a59421 to
6dfe1da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
random.multivariate_normalmean/covariance arguments to tensors before constructingtorch.distributions.MultivariateNormalRationale
The NumPy and JAX random backends accept ordinary array-like inputs for
random.multivariate_normal, e.g.random.multivariate_normal([0.0, 0.0], [[1.0, 0.0], [0.0, 1.0]], size=(6,)). The PyTorch backend passed these lists directly intotorch.distributions.MultivariateNormal, which fails because PyTorch expects tensor arguments.Validation
mainand behind by zero.src/pyrecest/_backend/pytorch/random.pyandtests/test_backend_random.py.